Beginner question

ArduL · 2018-10-14 11:39:04 UTC

Hello.

Why can i switch from screen 1 to screen 2 and inversely?

///////////////////////////////////////
#include <Arduboy2.h>

Arduboy2 arduboy;

bool Menu = 0;

void setup() {

  
  
  arduboy.begin();

  arduboy.setFrameRate(25);

  arduboy.clear();
  
}


void loop() {
  if (!(arduboy.nextFrame()))
    return;

  if ( arduboy.justPressed(B_BUTTON)) {
    if (Menu == 0) Menu = 1;
    else if (Menu == 1) Menu = 0;
  }


  switch (Menu) {
    case 0:
      arduboy.clear();
      arduboy.setCursor(10, (1 * 10));
      arduboy.print(F("Screen 1"));
      arduboy.display();
      break;
    case 1:
      arduboy.clear();
      arduboy.setCursor(10, (2 * 10));
      arduboy.print(F("Screen 2"));
      arduboy.display();
      break;
  }

}

MLXXXp · 2018-10-14 11:44:54 UTC

You’re missing a call to pollButtons() in loop()

void loop() {
  if (!(arduboy.nextFrame()))
    return;

  arduboy.pollButtons(); // <-- add this line

  if ( arduboy.justPressed(B_BUTTON)) {
...

ArduL · 2018-10-14 14:29:11 UTC

Thank you for your answer.

I’ve another problem with the Following code:

#include <Arduboy2.h>

Arduboy2 arduboy;


bool Menu = false;

int Menu_choice = 1;

void display_menu()
{
  arduboy.setCursor(10, (1 * 10));
  arduboy.print(F("Back"));
  arduboy.setCursor(10, (2 * 10));
  arduboy.print(F("New"));
  arduboy.setCursor(10, (3 * 10));
  arduboy.print(F("Load"));
  arduboy.setCursor(10, (4 * 10));
  arduboy.print(F("Save"));
}


void display_menu_cursor()
{
  arduboy.setCursor(0, (Menu_choice * 10));
  arduboy.print(F(">"));
}


void setup() {
  // initiate arduboy instance

  Serial.begin(9600);

  arduboy.begin();

  // here we set the framerate to 15, we do not need to run at
  // default 60 and it saves us battery life
  arduboy.setFrameRate(25);

  arduboy.clear();
  arduboy.setCursor(10, 10);
  arduboy.print(F("Screen 1"));
  arduboy.display();
}


// our main game loop, this runs once every cycle/frame.
// this is where our game logic goes.
void loop() {
  if (!(arduboy.nextFrame()))
    return;

  arduboy.pollButtons();

  if ( arduboy.justPressed(B_BUTTON) and Menu == false) {

    arduboy.clear();
    display_menu();
    display_menu_cursor();
    Menu = true;
  }

  Serial.print(Menu);

  switch (Menu) {
    case 0:
      arduboy.setCursor(10, 10);
      arduboy.print(F("Screen 1"));

      arduboy.display();
      break;



    case 1:
      if ( arduboy.justPressed(DOWN_BUTTON)) {
        arduboy.clear();
        Menu_choice++;
        if (Menu_choice >= 4)Menu_choice = 4;
        display_menu();
        display_menu_cursor();
      }

      if ( arduboy.justPressed(UP_BUTTON)) {
        arduboy.clear();
        Menu_choice--;
        if (Menu_choice <= 1)Menu_choice = 1;
        display_menu();
        display_menu_cursor();
      }

      if ( arduboy.justPressed(B_BUTTON) and Menu == true) {

        switch (Menu_choice) {
          case 1:
            arduboy.clear();
            arduboy.setCursor(10, 10);
            arduboy.print(F("Screen 1"));
            Menu = false;
            
            break;
          case 2:

            break;
          case 3:

            break;
          case 4:

            break;
        }
      }
      arduboy.display();
      break;
  }

}

when pushing button B Nothing happens because there is a loop that makes enter the menu and go away from it instantaneously. I Don’t know how to solve that.

filmote · 2018-10-14 23:51:32 UTC

Firstly, when you are postng code you need to wrap it within three back ticks (`).

A couple of problems:

if ( arduboy.justPressed(B_BUTTON) and Menu == false) {

  arduboy.clear(); 
  display_menu();
  display_menu_cursor();
  Menu = true;

}

If the player presses the B button, you immediately show the menu.

Then in this code …

switch (Menu) {
  case 0:
  ...
  break;

  case 1:
  ...
  if (arduboy.justPressed(B_BUTTON) and Menu == true) {

    switch (Menu_choice) {
      case 1:
        arduboy.clear();
        arduboy.setCursor(10, 10);
        arduboy.print(F("Screen 1"));
        Menu = false;
        ...
    }
  }

  arduboy.display();
  break;
}

You immediately clear the screen because within the same loop the criteria matches.

The problem is fundamentally how you have intertwined the logic for handling user and rendering the screen. You should restructure your code to do all of the user handling and then render the screen based on the results.

MLXXXp · 2018-10-15 11:41:00 UTC

I’ve formatted all the code examples in this topic by adding backticks where appropriate.

ArduL · 2018-10-15 17:59:50 UTC

Thank you for the answer filmote. That’s what i told you in my question.
If you wish to solve the problem what would you do?

Vampirics · 2018-10-15 18:43:32 UTC

Well to my understanding, you should make and put all update functions before the screen rendering function in your loop.

That way it won’t conflicts each other and display whatever had to be displayed after all the possible input from the player

Makes any more sense?

filmote · 2018-10-15 20:50:10 UTC

As @Vampirics and I have said, break out the button handling code and rendering code into two separate ‘sections’ rather than mixing them together.

filmote · 2018-10-15 22:36:53 UTC

Try this code:

#include <Arduboy2.h>

Arduboy2 arduboy;

bool menu = false;

int menu_choice = 1;

void displayMenu() {
  arduboy.setCursor(10, (1 * 10));
  arduboy.print(F("Back"));
  arduboy.setCursor(10, (2 * 10));
  arduboy.print(F("New"));
  arduboy.setCursor(10, (3 * 10));
  arduboy.print(F("Load"));
  arduboy.setCursor(10, (4 * 10));
  arduboy.print(F("Save"));
}

void displayMenuCursor() {
  arduboy.setCursor(0, (menu_choice * 10));
  arduboy.print(F(">"));
}

void setup() {

  // initiate arduboy instance
  arduboy.begin();

  // here we set the framerate to 15, we do not need to run at
  // default 60 and it saves us battery life
  arduboy.setFrameRate(25);

  arduboy.clear();
  arduboy.setCursor(10, 10);
  arduboy.print(F("Screen 1"));
  arduboy.display();
}

// our main game loop, this runs once every cycle/frame.
// this is where our game logic goes.
void loop() {

  if (!(arduboy.nextFrame())) return;
  arduboy.pollButtons();
  arduboy.clear();



  // Handle player input ..

  if (menu) {

    if (arduboy.justPressed(DOWN_BUTTON)) {
      menu_choice++;
      if (menu_choice >= 4) menu_choice = 4;
    }

    if (arduboy.justPressed(UP_BUTTON)) {
      menu_choice--;
      if (menu_choice <= 1) menu_choice = 1;
    }

    if (arduboy.justPressed(B_BUTTON)) {

      switch (menu_choice) {
      
        case 1:
          menu = false;
          break;

        case 2:
          // update the screen for the New function
          break;

        case 3:
          // update the screen for the Load function
          break;

        case 4:
          // update the screen for the Save function
          break;

      }

    }

  }
  else {
    
    if (arduboy.justPressed(B_BUTTON)) {
      menu = true;
    }
  
  }


  // Render screen and menu ..

  switch (menu) {

    case false:
      arduboy.setCursor(10, 10);
      arduboy.print(F("Screen 1"));
      break;

    case true:
      displayMenu();
      displayMenuCursor();
      break;

  }

  arduboy.display();

}

ArduL · 2018-10-19 11:55:57 UTC

Hello.
I’ve progressed in my project.
The code below contains exactly what i want to do with my arduboy. If you compile you’ll see how i want my program respond.
In the code there are only Menus, I find my organisation with menus messy so I just wanted to know if there are possibly improvements or not to make the code clearer that it is now.

Main file:

#include <Arduboy2.h>

#include "Functions.h"


void setup() {

  Serial.begin(9600);

  arduboy.begin();

  arduboy.setFrameRate(25);
  
}


void loop() {
  if (!(arduboy.nextFrame()))
    return;

  arduboy.pollButtons();
  arduboy.clear();

  /////////////////HANDLING//////////////////////////
  if (Menu == 1) {

    if (arduboy.justPressed(B_BUTTON)) {
      Menu = 2;
    }
    /////////////////////Do stuff//////////
  }

  else if (Menu == 2) {

    if (arduboy.justPressed(DOWN_BUTTON)) {
      Menu_choice++;
      if (Menu_choice >= 4) Menu_choice = 4;
    }

    if (arduboy.justPressed(UP_BUTTON)) {
      Menu_choice--;
      if (Menu_choice <= 1) Menu_choice = 1;
    }

    if (arduboy.justPressed(B_BUTTON)) {

      switch (Menu_choice) {

        case 1:
          Menu = 1;
          break;

        case 2:
          // update the screen for the New function
          Menu = 3;
          Last_menu_choice = 2;
          break;

        case 3:
          // update the screen for the Load function
          Menu = 4;
          Last_menu_choice = 3;
          break;

        case 4:
          // update the screen for the Save function
          Menu = 4;
          Last_menu_choice = 4;
          break;

      }
    }
  }

  else if (Menu == 3) {

    if (arduboy.justPressed(DOWN_BUTTON)) {
      Confirm_menu_choice++;
      if (Confirm_menu_choice >= 1) Confirm_menu_choice = 1;
    }

    if (arduboy.justPressed(UP_BUTTON)) {
      Confirm_menu_choice--;
      if (Confirm_menu_choice <= 0) Confirm_menu_choice = 0;
    }

    if (arduboy.justPressed(B_BUTTON)) {

      switch (Confirm_menu_choice) {

        case 0:
          // update the screen for the New function
          Confirm_menu_choice = 0;
          Menu = 2;
          break;

        case 1:

          if (Last_menu_choice == 2) {
            //Stuff for the 'NEW' choice
          }

          if (Last_menu_choice == 3) {
            //Stuff for the 'LOAD' choice
          }

          if (Last_menu_choice == 4) {
            //Stuff for the 'SAVE' choice
          }

          Menu = 1;
          break;
      }
    }
  }

  else if (Menu == 4) {

    if (arduboy.justPressed(DOWN_BUTTON)) {
      Slot_Menu_choice++;
      if (Slot_Menu_choice >= 4) Slot_Menu_choice = 4;
    }

    if (arduboy.justPressed(UP_BUTTON)) {
      Slot_Menu_choice--;
      if (Slot_Menu_choice <= 1) Slot_Menu_choice = 1;
    }

    if (arduboy.justPressed(B_BUTTON)) {
      Menu = 3;
    }
  }

  ///////////////////////////DISPLAY//////////////////////

  switch (Menu) {

    case 1:
      arduboy.setCursor(10, 10);
      arduboy.print(F("Screen 1"));
      break;

    case 2:
      display_menu();
      display_menu_cursor();
      break;

    case 3:
      display_confirm_menu();
      display_confirm_menu_cursor();
      break;

    case 4:
      display_slots_menu();
      display_slots_menu_cursor();
      break;

  }

  arduboy.display();
}

The functions.h file :

Arduboy2 arduboy;

int Menu = 1;

int Menu_choice = 1;

int Confirm_menu_choice = 0;

int Last_menu_choice;

int Slot_Menu_choice = 1;


void display_menu()
{
  arduboy.setCursor(10, (1 * 10));
  arduboy.print(F("Back"));
  arduboy.setCursor(10, (2 * 10));
  arduboy.print(F("New"));
  arduboy.setCursor(10, (3 * 10));
  arduboy.print(F("Load"));
  arduboy.setCursor(10, (4 * 10));
  arduboy.print(F("Save"));
}

void display_menu_cursor()
{
  arduboy.setCursor(0, (Menu_choice * 10));
  arduboy.print(F(">"));
}

void display_confirm_menu()
{
  arduboy.setCursor(10, (1 * 10));
  arduboy.print(F("Are you sure?"));
  arduboy.setCursor(10, (2 * 10));
  arduboy.print(F("NO"));
  arduboy.setCursor(10, (3 * 10));
  arduboy.print(F("YES"));
}

void display_confirm_menu_cursor()
{
  arduboy.setCursor(0, ((Confirm_menu_choice * 10) + 20));
  arduboy.print(F(">"));
}

void display_slots_menu()
{
  arduboy.setCursor(10, (1 * 10));
  arduboy.print(F("Slot 1"));
  arduboy.setCursor(10, (2 * 10));
  arduboy.print(F("Slot 2"));
  arduboy.setCursor(10, (3 * 10));
  arduboy.print(F("Slot 3"));
  arduboy.setCursor(10, (4 * 10));
  arduboy.print(F("Slot 4"));
}

void display_slots_menu_cursor()
{
  arduboy.setCursor(0, (Slot_Menu_choice * 10));
  arduboy.print(F(">"));
}

Pharap · 2018-10-19 22:21:20 UTC

Firstly, move the different menu handling into separate functions as well, not just the drawing functions.
E.g.

void updateScreen1(void)
{
	if (arduboy.justPressed(B_BUTTON))
	{
		Menu = 2;
	}
}

And then replace the if-else chain with another switch.

And secondly, use an enum class for Menu and Menu_choice:
E.g.

enum class Menu : uint8_t
{
	Screen1,
	Menu,
	ConfirmMenu,
	SlotsMenu,
};

Menu & operator++(Menu & menu)
{
	menu = static_cast<Menu>(static_cast<uint8_t>(menu) + 1);
	return menu;
}

Menu & operator--(Menu & menu)
{
	menu = static_cast<Menu>(static_cast<uint8_t>(menu) - 1);
	return menu;
}

enum class MenuChoice : uint8_t
{
	Back,
	New,
	Load,
	Save,
};

MenuChoice & operator++(MenuChoice & menuChoice)
{
	menuChoice = static_cast<MenuChoice>(static_cast<uint8_t>(menuChoice) + 1);
	return menuChoice;
}

MenuChoice & operator--(MenuChoice & menuChoice)
{
	menuChoice = static_cast<MenuChoice>(static_cast<uint8_t>(menuChoice) - 1);
	return menuChoice;
}

And to give an example of how to adapt your other code:

if (arduboy.justPressed(DOWN_BUTTON))
{
	if(Menu_choice < MenuChoice::Save)
		++Menu_choice;
}

if (arduboy.justPressed(UP_BUTTON))
{
	if(Menu_choice > MenuChoice::Back)
		--Menu_choice;
}

And:

switch (Menu)
{
	case Menu::Screen1:
		arduboy.setCursor(10, 10);
		arduboy.print(F("Screen 1"));
		break;

	case Menu::Menu:
		display_menu();
		display_menu_cursor();
		break;

	case Menu::ConfirmMenu:
		display_confirm_menu();
		display_confirm_menu_cursor();
		break;

	case Menu::SlotsMenu:
		display_slots_menu();
		display_slots_menu_cursor();
		break;
}

ArduL · 2018-10-20 08:40:33 UTC

Thank for your answer Pharap but you know the way you code is out of my hands.
Class methods are Something i Don’t understand yet, for the future i want to add more code.
I’d rather have a simpler answer that i’ll master.

Your answer was very kind but i cannote use it.

Can someone help me?

filmote · 2018-10-20 12:34:49 UTC

ArduL:

void loop() { if (!(arduboy.nextFrame())) return; 

  arduboy.pollButtons(); 
  arduboy.clear(); 

  if (Menu == 1) { 
    if (arduboy.justPressed(B_BUTTON)) { 
      Menu = 2; 
    } 
  } 
  else if (Menu == 2) {
    ...

I would change the outer if … then … else to a switch statement as well.

Then (stealing @pharap’s code), I would change the constants 1 and 2 to an enum.

enum class Menu : uint8_t {
	Screen1,
	Menu,
	ConfirmMenu,
	SlotsMenu,
};

to look like …

void loop() { if (!(arduboy.nextFrame())) return; 

  arduboy.pollButtons(); 
  arduboy.clear(); 

  switch (Menu)  {

    case Menu::Screen1:
      if (arduboy.justPressed(B_BUTTON)) {
        Menu = 2;
      }
      break;

    case Menu::Menu:
      if (arduboy.justPressed(DOWN_BUTTON)) {
        Menu_choice++;
        if (Menu_choice >= 4) Menu_choice = 4;
      }
     ... 
     break;

I would also look at the lines like this:

      Menu_choice++;
      if (Menu_choice >= 4) Menu_choice = 4;

Could these be switched to?

  if (Menu_choice < 4) Menu_choice++;

ArduL · 2018-10-20 13:18:38 UTC

Hello.

I receive an error when compiling:
(‘Menu’ is not a class, namespace, or enumeration) at the line 124:

#include <Arduboy2.h>

#include "Functions.h"

enum class Menu : uint8_t {
  Screen1,
  Menu,
  ConfirmMenu,
  SlotsMenu,
};


void setup() {

  Serial.begin(9600);

  arduboy.begin();

  arduboy.setFrameRate(25);

}


void loop() {
  if (!(arduboy.nextFrame())) return;

  arduboy.pollButtons();
  arduboy.clear();

  /////////////////HANDLING//////////////////////////
  switch (Menu)  {

    case Menu::Screen1:
      if (arduboy.justPressed(B_BUTTON)) {
        Menu = 2;
      }
      break;


    case Menu::Menu:

      if (arduboy.justPressed(DOWN_BUTTON)) {
        if (Menu_choice < 4) Menu_choice++;
      }

      if (arduboy.justPressed(UP_BUTTON)) {
        if (Menu_choice > 1) Menu_choice++;
      }

      if (arduboy.justPressed(B_BUTTON)) {

        switch (Menu_choice) {

          case 1:
            Menu = 1;
            break;

          case 2:
            // update the screen for the New function
            Menu = 3;
            Last_menu_choice = 2;
            break;

          case 3:
            // update the screen for the Load function
            Menu = 4;
            Last_menu_choice = 3;
            break;

          case 4:
            // update the screen for the Save function
            Menu = 4;
            Last_menu_choice = 4;
            break;

        }
      }

      break;

    case Menu::ConfirmMenu:

      if (arduboy.justPressed(DOWN_BUTTON)) {
        if (Confirm_menu_choice < 1) Confirm_menu_choice++;
      }

      if (arduboy.justPressed(UP_BUTTON)) {
        if (Confirm_menu_choice > 0) Confirm_menu_choice--;
      }

      if (arduboy.justPressed(B_BUTTON)) {

        switch (Confirm_menu_choice) {

          case 0:
            // update the screen for the New function
            Confirm_menu_choice = 0;
            Menu = 2;
            break;

          case 1:

            if (Last_menu_choice == 2) {
              //Stuff for the 'NEW' choice
            }

            if (Last_menu_choice == 3) {
              //Stuff for the 'LOAD' choice
            }

            if (Last_menu_choice == 4) {
              //Stuff for the 'SAVE' choice
            }

            Menu = 1;
            break;
        }
      }


      break;


    case Menu::SlotsMenu:

      if (arduboy.justPressed(DOWN_BUTTON)) {
        if (Slot_Menu_choice < 4) Slot_Menu_choice++;
      }

      if (arduboy.justPressed(UP_BUTTON)) {
        if (Slot_Menu_choice > 1) Slot_Menu_choice--;
      }

      if (arduboy.justPressed(B_BUTTON)) {
        Menu = 3;
      }

      break;

  }
  ///////////////////////////DISPLAY//////////////////////

  switch (Menu) {

    case 1:
      arduboy.setCursor(10, 10);
      arduboy.print(F("Screen 1"));
      break;

    case 2:
      display_menu();
      display_menu_cursor();
      break;

    case 3:
      display_confirm_menu();
      display_confirm_menu_cursor();
      break;

    case 4:
      display_slots_menu();
      display_slots_menu_cursor();
      break;

  }

  arduboy.display();
}

I have to say that i wish to remove the ‘Last_menu_choice’ variable that is in the ‘Menu_choice’ switch.
That’s all i want by now.

drummyfish · 2018-10-20 13:42:46 UTC

This seems to be wrong?

switch (Menu)  {

You should do switch on a variable, but Menu is not a variable, it’s a type. You should make a variable

Menu menu;

And then do

switch (menu)

ArduL · 2018-10-20 13:56:56 UTC

No drummyfish. That’s the same error.

drummyfish · 2018-10-20 14:17:08 UTC

I could tell you if I could compile the code, but I’m missing your Functions.h file. Do you have the whole code somewhere?

EDIT:

There’s more stuff that will prevent it from compiling as I’m looking at it.

ArduL · 2018-10-20 14:23:19 UTC

functions.h

Arduboy2 arduboy;



int Menu = 1;

int Menu_choice = 1;

int Confirm_menu_choice = 0;

int Last_menu_choice;

int Slot_Menu_choice = 1;


void display_menu()
{
  arduboy.setCursor(10, (1 * 10));
  arduboy.print(F("Back"));
  arduboy.setCursor(10, (2 * 10));
  arduboy.print(F("New"));
  arduboy.setCursor(10, (3 * 10));
  arduboy.print(F("Load"));
  arduboy.setCursor(10, (4 * 10));
  arduboy.print(F("Save"));
}

void display_menu_cursor()
{
  arduboy.setCursor(0, (Menu_choice * 10));
  arduboy.print(F(">"));
}

void display_confirm_menu()
{
  arduboy.setCursor(10, (1 * 10));
  arduboy.print(F("Are you sure?"));
  arduboy.setCursor(10, (2 * 10));
  arduboy.print(F("NO"));
  arduboy.setCursor(10, (3 * 10));
  arduboy.print(F("YES"));
}

void display_confirm_menu_cursor()
{
  arduboy.setCursor(0, ((Confirm_menu_choice * 10) + 20));
  arduboy.print(F(">"));
}

void display_slots_menu()
{
  arduboy.setCursor(10, (1 * 10));
  arduboy.print(F("Slot 1"));
  arduboy.setCursor(10, (2 * 10));
  arduboy.print(F("Slot 2"));
  arduboy.setCursor(10, (3 * 10));
  arduboy.print(F("Slot 3"));
  arduboy.setCursor(10, (4 * 10));
  arduboy.print(F("Slot 4"));
}

void display_slots_menu_cursor()
{
  arduboy.setCursor(0, (Slot_Menu_choice * 10));
  arduboy.print(F(">"));
}

drummyfish · 2018-10-20 14:31:03 UTC

Thanks, I’ll look at it. I’ll keep adding things in this list:

Functions.h should have #include <Arduboy2.h> at the top, because now it relies on the main file to do this before including functions.h – that’s not a good practice, if a file uses a library, it should include it itself. (You can still include it in the main file as well.)
The cause of the error you’re getting is that in functions.h you already have a variable named Menu, and you’re then trying to declare an enum named Menu as well in the main file. To avoid this, name variables lowecase, that is menu, and types (for example enums) with starting uppercase, that is Menu. So you should delete the int Menu = 1; from functions.h, and instead create Menu menu = Menu::Menu; in the main file, somewhere after the enum class Menu .... Then you must change all places where you assign integers to menu (such as menu = 2) to assigning the enum values instead (e.g. menu = Menu::ConfirmMenu). Also everywhere you do switch (menu) you must use the enum values instead of integers in the case labels (e.g. case Menu::Screen1: instead of case 0:).
You should add #pragma once at the beginning of the functions.h file – it’s not an error at this moment, but it helps prevent some in the future.

Okay, here are the files edited so that they compile:

main:

Summary

#include <Arduboy2.h>

#include "Functions.h"

enum class Menu : uint8_t {
  Screen1,
  Menu,
  ConfirmMenu,
  SlotsMenu,
};

Menu menu = Menu::Menu;

void setup() {
  Serial.begin(9600);
  arduboy.begin();
  arduboy.setFrameRate(25);
}


void loop() {

  if (!(arduboy.nextFrame())) return;

  arduboy.pollButtons();
  arduboy.clear();

  /////////////////HANDLING//////////////////////////
  switch (menu)  {

    case Menu::Screen1:
      if (arduboy.justPressed(B_BUTTON)) {
        menu = Menu::ConfirmMenu;
      }
      break;


    case Menu::Menu:

      if (arduboy.justPressed(DOWN_BUTTON)) {
        if (menu_choice < 4) menu_choice++;
      }

      if (arduboy.justPressed(UP_BUTTON)) {
        if (menu_choice > 1) menu_choice++;
      }

      if (arduboy.justPressed(B_BUTTON)) {

        switch (menu_choice) {

          case 1:
            menu = Menu::Screen1;
            break;

          case 2:
            // update the screen for the New function
            menu = Menu::SlotsMenu;
            last_menu_choice = 2;
            break;

          case 3:
            // update the screen for the Load function
            menu = Menu::SlotsMenu;
            last_menu_choice = 3;
            break;

          case 4:
            // update the screen for the Save function
            menu = Menu::SlotsMenu;
            last_menu_choice = 4;
            break;

        }
      }

      break;

    case Menu::ConfirmMenu:

      if (arduboy.justPressed(DOWN_BUTTON)) {
        if (confirm_menu_choice < 1) confirm_menu_choice++;
      }

      if (arduboy.justPressed(UP_BUTTON)) {
        if (confirm_menu_choice > 0) confirm_menu_choice--;
      }

      if (arduboy.justPressed(B_BUTTON)) {

        switch (confirm_menu_choice) {

          case 0:
            // update the screen for the New function
            confirm_menu_choice = 0;
            menu = Menu::ConfirmMenu;
            break;

          case 1:

            if (last_menu_choice == 2) {
              //Stuff for the 'NEW' choice
            }

            if (last_menu_choice == 3) {
              //Stuff for the 'LOAD' choice
            }

            if (last_menu_choice == 4) {
              //Stuff for the 'SAVE' choice
            }

            menu = Menu::Menu;
            break;
        }
      }


      break;


    case Menu::SlotsMenu:

      if (arduboy.justPressed(DOWN_BUTTON)) {
        if (slot_menu_choice < 4) slot_menu_choice++;
      }

      if (arduboy.justPressed(UP_BUTTON)) {
        if (slot_menu_choice > 1) slot_menu_choice--;
      }

      if (arduboy.justPressed(B_BUTTON)) {
        menu = Menu::SlotsMenu;
      }

      break;

  }
  ///////////////////////////DISPLAY//////////////////////

  switch (menu) {

    case Menu::Screen1:
      arduboy.setCursor(10, 10);
      arduboy.print(F("Screen 1"));
      break;

    case Menu::Menu:
      display_menu();
      display_menu_cursor();
      break;

    case Menu::ConfirmMenu:
      display_confirm_menu();
      display_confirm_menu_cursor();
      break;

    case Menu::SlotsMenu:
      display_slots_menu();
      display_slots_menu_cursor();
      break;

  }

  arduboy.display();
}

Functions.h

Summary

#pragma once
#include <Arduboy2.h>

Arduboy2 arduboy;



int menu_choice = 1;

int confirm_menu_choice = 0;

int last_menu_choice;

int slot_menu_choice = 1;


void display_menu()
{
  arduboy.setCursor(10, (1 * 10));
  arduboy.print(F("Back"));
  arduboy.setCursor(10, (2 * 10));
  arduboy.print(F("New"));
  arduboy.setCursor(10, (3 * 10));
  arduboy.print(F("Load"));
  arduboy.setCursor(10, (4 * 10));
  arduboy.print(F("Save"));
}

void display_menu_cursor()
{
  arduboy.setCursor(0, (menu_choice * 10));
  arduboy.print(F(">"));
}

void display_confirm_menu()
{
  arduboy.setCursor(10, (1 * 10));
  arduboy.print(F("Are you sure?"));
  arduboy.setCursor(10, (2 * 10));
  arduboy.print(F("NO"));
  arduboy.setCursor(10, (3 * 10));
  arduboy.print(F("YES"));
}

void display_confirm_menu_cursor()
{
  arduboy.setCursor(0, ((confirm_menu_choice * 10) + 20));
  arduboy.print(F(">"));
}

void display_slots_menu()
{
  arduboy.setCursor(10, (1 * 10));
  arduboy.print(F("slot 1"));
  arduboy.setCursor(10, (2 * 10));
  arduboy.print(F("slot 2"));
  arduboy.setCursor(10, (3 * 10));
  arduboy.print(F("slot 3"));
  arduboy.setCursor(10, (4 * 10));
  arduboy.print(F("slot 4"));
}

void display_slots_menu_cursor()
{
  arduboy.setCursor(0, (slot_menu_choice * 10));
  arduboy.print(F(">"));
}

But I’ve messed with the switches and they won’t do what they’re supposed to, and I think you shouldn’t use this anyway. I’d suggest we could write this all in a slightly better way, okay? What exactly are you trying to achieve?

EDIT:

Okay, I see what you’re doing. I’m thinking about how to create a dead-simple menu implementation. @Pharap, do you maybe know any elegant pattern for menus?

ArduL · 2018-10-20 15:51:36 UTC

i’ve made a simple Schematic in the attached file.